Configless debug #557
Open
Configless debug #557
+318
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
karthiknadig
requested changes
Jan 15, 2025
| ], | ||
| "outFiles": [ | ||
| "${workspaceFolder}/out/**/*.js", | ||
| ], | ||
| "preLaunchTask": "tasks: watch-tests" | ||
| }, | ||
| "preLaunchTask": "tasks: watch-tests" }, |
There was a problem hiding this comment.
This file seems like it might have formatting issues.
Comment on lines
+40
to
+41
| context.subscriptions.push( | ||
| createFileSystemWatcher(new RelativePattern(debugAdapterEndpointDir, '**/*')).onDidCreate((uri) => { |
There was a problem hiding this comment.
You need to dispose both the watcher and the event, here only the event is being disposed.
Comment on lines
+62
to
+68
| { | ||
| type: 'python', | ||
| request: 'attach', | ||
| name: 'Attach to Python', | ||
| port: clientPort, | ||
| host: 'localhost', | ||
| }, |
There was a problem hiding this comment.
You should use the connect field, instead of host and port directly here.
There was a problem hiding this comment.
I think you can make this whole thing async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support debugging with no config required