-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite trx when file name is explicitly provided #4654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs:209
- [nitpick] The warning message 'Warning: Trx file '{finalFileName}' already exists and is overwritten.' could be more informative. Consider rephrasing to 'Warning: The TRX file '{finalFileName}' already existed and was overwritten.'
return isFileNameExplicitlyProvided && _fileSystem.Exists(finalFileName) ? (finalFileName, $"Warning: Trx file '{finalFileName}' already exists and is overwritten.") : (finalFileName, null);
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assert the expected message somewhere?
Fixes #4561