Overwrite trx when file name is explicitly provided #4654
Merged
+197
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
requested review from
MarcoRossignoli and
Evangelink
as code owners
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs:209
- [nitpick] The warning message 'Warning: Trx file '{finalFileName}' already exists and is overwritten.' could be more informative. Consider rephrasing to 'Warning: The TRX file '{finalFileName}' already existed and was overwritten.'
return isFileNameExplicitlyProvided && _fileSystem.Exists(finalFileName) ? (finalFileName, $"Warning: Trx file '{finalFileName}' already exists and is overwritten.") : (finalFileName, null);
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Jan 15, 2025
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resx
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4561