Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Implement MongoDB Atlas store #10177

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented Jan 14, 2025

Implement a new version of the MongoDB Atlas Memory Connector with MongoDBAtlasStore and MongoDBAtlasCollection classes.

  • MongoDBAtlasStore:

    • Add python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_store.py to implement the MongoDBAtlasStore class.
    • Add unit tests in python/tests/unit/connectors/memory/mongodb_atlas/test_mongodb_atlas_store.py to test the MongoDBAtlasStore class.
  • MongoDBAtlasCollection:

    • Add python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_collection.py to implement the MongoDBAtlasCollection class.
    • Add unit tests in python/tests/unit/connectors/memory/mongodb_atlas/test_mongodb_atlas_collection.py to test the MongoDBAtlasCollection class.

For more details, open the Copilot Workspace session.

closes #6764

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner January 14, 2025 08:14
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Jan 14, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 14, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/memory/mongodb_atlas
   mongodb_atlas_collection.py1284664%85, 107–108, 116, 133, 140, 162–164, 170–172, 179, 183, 192–194, 198, 202, 213–241, 248–254, 258, 262, 272–273
   mongodb_atlas_store.py48688%80–81, 129–130, 134–135
   utils.py311068%38–40, 62, 86–88, 106–113
TOTAL16915183889% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3007 4 💤 0 ❌ 0 🔥 1m 25s ⏱️

eavanvalkenburg and others added 3 commits January 15, 2025 11:21
Implement a new version of the MongoDB Atlas Memory Connector with MongoDBAtlasStore and MongoDBAtlasCollection classes.

* **MongoDBAtlasStore**:
  - Add `python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_store.py` to implement the MongoDBAtlasStore class.
  - Add unit tests in `python/tests/unit/test_mongodb_atlas_store.py` to test the MongoDBAtlasStore class.

* **MongoDBAtlasCollection**:
  - Add `python/semantic_kernel/connectors/memory/mongodb_atlas/mongodb_atlas_collection.py` to implement the MongoDBAtlasCollection class.
  - Add unit tests in `python/tests/unit/test_mongodb_atlas_collection.py` to test the MongoDBAtlasCollection class.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/semantic-kernel?shareId=XXXX-XXXX-XXXX-XXXX).
@eavanvalkenburg eavanvalkenburg force-pushed the eavanvalkenburg/python-mongodb-atlas-store branch from 3dd77d2 to 3aecfbd Compare January 15, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Update MongoDB Atlas Memory Connector to new Vector Search Design
2 participants