Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical screenshots for firefox with webdriver bidi for screenshot element tests #34289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lutien
Copy link
Contributor

@lutien lutien commented Jan 10, 2025

  • add canonical screenshots for Firefox with WebDriver BiDi for screenshot element tests
  • add a canonical screenshot for locator test

This comment has been minimized.

@@ -168,7 +168,8 @@ it.describe('element screenshot', () => {

it('should work with a rotated element', async ({ page }) => {
await page.setViewportSize({ width: 500, height: 500 });
await page.setContent(`<div style="position:absolute;
await page.setContent(`<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need to modify tests to make them pass. If Firefox behaves differently w/o doctype we should fix it elsewhere (prepend DOCTYPE when settings content or differently)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I've removed the doctype update from this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavelfeldman if the doctype should be added somewhere else, do you mean directly in the page.setContent implementation of Playwright? Quirks mode is expected to have differences in browsers, but if there are cases when you actually want to test that it won't be possible unless another argument to eg. page.setContent is added, which would enable it as fallback.

Mind sharing what is your exact proposal here? Thanks!

@lutien lutien force-pushed the add-more-canonical-screenshots-for-firefox-with-webdriver-bidi branch from 6de4926 to 4d613b3 Compare January 13, 2025 09:14
@lutien lutien changed the title Add canonical screenshots for firefox with webdriver bidi and doctype for screenshot element tests Add canonical screenshots for firefox with webdriver bidi for screenshot element tests Jan 13, 2025

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node22
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1206:1 › should ignore 304 responses @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:322:5 › launchServer › should set the browser connected state @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:192:1 › should render network bars @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1469:1 › should not record network actions @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:187:5 › screencast › should capture static page @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-output.spec.ts:80:5 › should show console messages for test @windows-latest-node18-1

37578 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants