If both PaneHeader and PaneTitle are set, use PaneHeader #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
reviewed
Mar 11, 2019
|
|
||
| [WUXC_VERSION_MUXONLY] | ||
| { | ||
| String PaneTitle{ get; }; |
There was a problem hiding this comment.
New APIs require API doc (since this will appear on MSDN). Please do that process before completing this PR. You can model your doc after this one: microsoft/microsoft-ui-xaml-specs#13.
jevansaks
suggested changes
Mar 11, 2019
chrisglein
approved these changes
Mar 13, 2019
|
Before this change, are we displaying both the PaneTitle and the PaneHeader when both are set? |
|
yes. it's internal bug |
|
This pull is abandoned and would make doc change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaneTitle is just a string, and we introduced PaneHeader to replace it. If both are set, use PaneHeader.