Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support for Service tool added. #3573

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Windows support for Service tool added. #3573

wants to merge 7 commits into from

Conversation

SRIKKANTH
Copy link
Collaborator

@SRIKKANTH SRIKKANTH commented Dec 30, 2024 •
edited
Loading

This pull request adds Windows support for the Service tool.

@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch 5 times, most recently from 5678bbc to 2f38007 Compare December 30, 2024 20:05
squirrelsc
squirrelsc reviewed Dec 30, 2024
View reviewed changes
lisa/schema.py Outdated Show resolved Hide resolved
@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch from 9cfc7ab to 727572d Compare January 1, 2025 08:18
@SRIKKANTH SRIKKANTH marked this pull request as ready for review January 1, 2025 08:23
@SRIKKANTH SRIKKANTH requested a review from LiliDeng as a code owner January 1, 2025 08:23
@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch 2 times, most recently from 72582c5 to 30a8249 Compare January 2, 2025 05:55
@SRIKKANTH SRIKKANTH mentioned this pull request Jan 2, 2025
Open
@squirrelsc
Copy link
Member

@LiliDeng LGTM

@LiliDeng
Copy link
Collaborator

Please fix CI check error @SRIKKANTH

@LiliDeng
Copy link
Collaborator

@SRIKKANTH please rebase latest main, it will fix the CI check error.

@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch from 8e3a7c3 to 96b8bfa Compare January 15, 2025 12:14
@SRIKKANTH
Copy link
Collaborator Author

@SRIKKANTH please rebase latest main, it will fix the CI check error.

Fixed all CI check errors. please complete the PR @LiliDeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squirrelsc squirrelsc squirrelsc left review comments

@LiliDeng LiliDeng Awaiting requested review from LiliDeng LiliDeng is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SRIKKANTH @squirrelsc @LiliDeng