Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing module registration logic + Implementing no-op & JSON module benchmarking #917

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

TalZaccai
Copy link
Contributor

@TalZaccai TalZaccai commented Jan 15, 2025

  • Fixing module registration to allow registration in multiple in-proc server instances
  • Implementing NoOpModule to have a baseline for module benchmarking
  • Implementing ModuleOperations in BDN.benchmark containing benchmarking logic for no-op module and JSON module operations.

Initial benchmarking results:

Method Params Mean Error StdDev Median Gen0 Allocated
ModuleNoOpRawStringReadCommand ACL 52.38 us 1.669 us 4.921 us 51.75 us - 2400 B
ModuleNoOpRawStringRmwCommand ACL 52.96 us 0.835 us 0.962 us 52.57 us - -
ModuleNoOpObjRmwCommand ACL 78.89 us 1.572 us 1.470 us 78.37 us - 8800 B
ModuleNoOpObjReadCommand ACL 65.52 us 0.932 us 0.778 us 65.52 us - 5600 B
ModuleNoOpProc ACL 43.82 us 0.354 us 0.296 us 43.82 us - 2400 B
ModuleNoOpTxn ACL 36.56 us 0.593 us 0.526 us 36.40 us - 2400 B
ModuleJsonGetCommand ACL 119.17 us 1.689 us 1.580 us 118.75 us - 69600 B
ModuleJsonSetCommand ACL 224.60 us 4.271 us 7.252 us 222.91 us 0.7324 228800 B
ModuleNoOpRawStringReadCommand AOF 45.46 us 0.863 us 0.721 us 45.35 us - 2400 B
ModuleNoOpRawStringRmwCommand AOF 57.56 us 0.527 us 0.493 us 57.47 us - -
ModuleNoOpObjRmwCommand AOF 83.59 us 1.086 us 0.848 us 83.77 us - 8800 B
ModuleNoOpObjReadCommand AOF 109.78 us 10.179 us 30.013 us 97.60 us - 5600 B
ModuleNoOpProc AOF 52.95 us 2.106 us 5.764 us 51.82 us - 2400 B
ModuleNoOpTxn AOF 43.15 us 0.769 us 1.930 us 42.73 us - 2400 B
ModuleJsonGetCommand AOF 120.65 us 1.473 us 1.305 us 120.37 us - 69600 B
ModuleJsonSetCommand AOF 233.67 us 4.502 us 4.211 us 232.39 us 0.4883 228800 B
ModuleNoOpRawStringReadCommand None 45.86 us 0.577 us 0.540 us 45.77 us - 2400 B
ModuleNoOpRawStringRmwCommand None 53.18 us 0.871 us 0.815 us 52.94 us - -
ModuleNoOpObjRmwCommand None 79.95 us 1.532 us 1.433 us 79.49 us - 8800 B
ModuleNoOpObjReadCommand None 65.84 us 0.478 us 0.424 us 65.68 us - 5600 B
ModuleNoOpProc None 45.80 us 0.845 us 1.156 us 45.27 us - 2400 B
ModuleNoOpTxn None 37.08 us 0.353 us 0.295 us 37.10 us - 2400 B
ModuleJsonGetCommand None 122.21 us 2.434 us 3.332 us 121.33 us - 69600 B
ModuleJsonSetCommand None 229.76 us 4.317 us 4.619 us 228.49 us 0.7324 228800 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant