-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to 1.1.0 TES spec compliance #653
Conversation
Fixes #479 |
@vsmalladi according to ADO, all compliance tests failed --- @MattMcL4475 the error seems like the TES api was not reachable, did something change about how we connect to it? error: Exception Name - OS Error. Type - TestRunnerException. Message - Connection error to POST http://tes:***@tesinttest-53111467-5761-05994.southcentralus.cloudapp.azure.com/v1/tasks. Details - HTTPSConnectionPool(host='tesinttest-53111467-5761-05994.southcentralus.cloudapp.azure.com', port=443): Max retries exceeded with url: /v1/tasks (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1135)'))) |
That means that the Certificate Manager in Kubernetes hasn't yet installed the LetsEncrypt certificate, which is definitely an environmental issue. However, by the time the compliance tests run, that cert should have been installed already. We get around that for the deployer's smoke test by using OTOH, not having a working certificate will prevent the deployment from being used by the end user, so the cert manager issue needs to be dealt with somehow. |
@BMurri thanks for the context. wonder if the failure was a random thing (something with the set up just didnt go right) - will try to rerun and see if that is still happening. |
@yuliadub any luck to see if this is fixed on a rerun? |
@vsmalladi did you try to push an update to this PR to kick off another run? If not, I suggest you do. from looking at the test running on other branches, it is working: https://malibu00.visualstudio.com/Emmons/_releaseProgress?_a=release-environment-logs&releaseId=6229&environmentId=7183 |
@yuliadub i have merged in main and tests are running now. Below are 1.0.0 and 1.1.0 outputs
Tests failing now:
The other two fail due to a response return. That should be solved by PR #664 |
this PR claims to fix #479 but all it does is add the output from the tests, so I am a bit confused -- are there separate PRs that actually edit TES code to fix tests? for adding support for 1.1 things looks good to me. |
@yuliadub yes I had to update the compliance tests with this PR elixir-cloud-aai/openapi-test-runner#70 THat is now merged in so now Service info passes as part of the tests. |
@vsmalladi I see - so the error was on the compliance test side, not us - I am sorry I totally missed that part. if that is the case, looks good to me. (a brief summary of all that in this PR could have helped clear that up vs just links to the issues, although now I do see the link to the elixir PR in one of the issue comments that I missed earlier) |
@yuliadub thanks updated the summary. |
fixes #254
fixes #479