Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-charting): Heatmap text color based on Contrast Ratio #33659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(react-charting): Heatmap text color based on Contrast Ratio #33659

wants to merge 4 commits into from
+476 −410

Conversation

Anush2303
Copy link
Contributor

New Behavior

image

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2025 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
ExtendedPicker		 96.873 kB
27.893 kB		 96.873 kB
27.892 kB
-1 B
react
FloatingPicker		 242.366 kB
69.001 kB		 242.366 kB
69.002 kB
1 B
react
Fluent UI React (entire library)		 1.018 MB
282.933 kB		 1.018 MB
282.934 kB
1 B
react
SelectedItemsList		 232.878 kB
67.891 kB		 232.878 kB
67.893 kB
2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
keyboard-keys
Multiple keyCodes		 50 B
70 B
keyboard-keys
Multiple keys		 87 B
94 B
keyboard-keys
Single key		 44 B
64 B
keyboard-keys
Single keyCode		 39 B
59 B
priority-overflow
createOverflowManager		 4.457 kB
1.856 kB
react
ActivityItem		 71.236 kB
23.357 kB
react
Announced		 38.489 kB
13.296 kB
react
Autofill		 15.42 kB
4.766 kB
react
Breadcrumb		 202.318 kB
60.388 kB
react
Button		 195.791 kB
56.627 kB
react
ButtonGrid		 180.722 kB
54.627 kB
react
Calendar		 121.875 kB
37.024 kB
react
Callout		 84.323 kB
27.64 kB
react
Check		 53.204 kB
17.848 kB
react
Checkbox		 59.985 kB
19.903 kB
react
ChoiceGroup		 65.494 kB
21.489 kB
react
ChoiceGroupOption		 58.767 kB
19.362 kB
react
Coachmark		 93.144 kB
29.42 kB
react
Color		 7.789 kB
3.127 kB
react
ColorPicker		 135.292 kB
42.21 kB
react
ComboBox		 252.24 kB
72.304 kB
react
CommandBar		 203.359 kB
60.141 kB
react
ContextualMenu		 155.243 kB
48.202 kB
react
DatePicker		 184.295 kB
56.15 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 229.909 kB
65.781 kB
react
Dialog		 211.717 kB
63.165 kB
react
Divider		 19.603 kB
6.845 kB
react
DocumentCard		 217.336 kB
64.44 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 34.303 kB
11.511 kB
react
Dropdown		 234.695 kB
68.743 kB
react
Fabric		 41.745 kB
14.366 kB
react
Facepile		 210.893 kB
63.167 kB
react
FocusTrapZone		 17.023 kB
5.911 kB
react
FocusZone		 55.159 kB
17.492 kB
react
Grid		 180.722 kB
54.627 kB
react
GroupedList		 135.07 kB
40.7 kB
react
GroupedListV2		 122.687 kB
37.788 kB
react
HoverCard		 97.16 kB
30.787 kB
react
Icon		 51.885 kB
17.272 kB
react
Icons		 66.361 kB
24.397 kB
react
Image		 46.904 kB
15.707 kB
react
Keytip		 81.693 kB
26.766 kB
react
KeytipData		 14.032 kB
4.582 kB
react
KeytipLayer		 103.474 kB
32.015 kB
react
Keytips		 106.238 kB
33.013 kB
react
Label		 38.347 kB
13.257 kB
react
Layer		 48.099 kB
16.367 kB
react
Link		 39.682 kB
13.67 kB
react
List		 39.371 kB
12.463 kB
react
MarqueeSelection		 74.517 kB
22.433 kB
react
MessageBar		 190.869 kB
57.103 kB
react
Modal		 93.738 kB
30.271 kB
react
Nav		 188.306 kB
56.485 kB
react
OverflowSet		 33.385 kB
11.314 kB
react
Overlay		 40.902 kB
14.095 kB
react
Panel		 201.808 kB
60.106 kB
react
Persona		 114.948 kB
36.532 kB
react
PersonaCoin		 114.948 kB
36.532 kB
react
PersonaPresence		 58.074 kB
19.384 kB
react
Pickers		 299.004 kB
83.632 kB
react
Pivot		 189.226 kB
57.267 kB
react
Popup		 12.294 kB
4.195 kB
react
Positioning		 22.807 kB
7.701 kB
react
PositioningContainer		 73.85 kB
23.765 kB
react
ProgressIndicator		 39.494 kB
13.55 kB
react
Rating		 82.12 kB
26.127 kB
react
ResizeGroup		 13.338 kB
4.377 kB
react
ResponsiveMode		 8.13 kB
2.966 kB
react
ScrollablePane		 55.557 kB
17.728 kB
react
SearchBox		 189.118 kB
56.68 kB
react
SelectableOption		 724 B
413 B
react
Selection		 42.444 kB
12.278 kB
react
Separator		 35.384 kB
12.146 kB
react
Shimmer		 49.259 kB
16.268 kB
react
ShimmeredDetailsList		 240.691 kB
68.532 kB
react
Slider		 57.651 kB
19.217 kB
react
SpinButton		 192.821 kB
57.775 kB
react
Spinner		 41.775 kB
14.48 kB
react
Stack		 42.074 kB
14.405 kB
react
Sticky		 32.599 kB
10.504 kB
react
Styling		 46.033 kB
15.135 kB
react
SwatchColorPicker		 191.136 kB
58.151 kB
react
TeachingBubble		 206.139 kB
61.063 kB
react
Text		 36.908 kB
12.822 kB
react
TextField		 80.79 kB
25.315 kB
react
Theme		 43.493 kB
14.173 kB
react
ThemeGenerator		 12.392 kB
4.126 kB
react
TimePicker		 242.051 kB
70.061 kB
react
Toggle		 46.225 kB
15.986 kB
react
Tooltip		 87.437 kB
28.26 kB
react
Utilities		 82.931 kB
25.148 kB
react
Viewport		 23.888 kB
7.656 kB
react
WeeklyDayPicker		 102.017 kB
31.834 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 107.176 kB
32.824 kB
react-aria
ARIA - Default		 237 B
181 B
react-avatar
Avatar		 49.329 kB
15.824 kB
react-avatar
AvatarGroup		 20.132 kB
7.976 kB
react-avatar
AvatarGroupItem		 63.473 kB
20.043 kB
react-badge
Badge		 25.98 kB
8.602 kB
react-badge
CounterBadge		 26.759 kB
8.879 kB
react-badge
PresenceBadge		 25.745 kB
9.463 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.317 kB
31.702 kB
react-button
Button		 37.2 kB
10.811 kB
react-button
CompoundButton		 43.614 kB
12.109 kB
react-button
MenuButton		 42.015 kB
12.152 kB
react-button
SplitButton		 50.032 kB
13.724 kB
react-button
ToggleButton		 53.133 kB
12.569 kB
react-calendar-compat
Calendar Compat		 150.095 kB
40.026 kB
react-card
Card - All		 101.796 kB
28.779 kB
react-card
Card		 94.57 kB
26.957 kB
react-card
CardFooter		 14.381 kB
5.799 kB
react-card
CardHeader		 16.914 kB
6.677 kB
react-card
CardPreview		 14.446 kB
5.929 kB
react-checkbox
Checkbox		 35.144 kB
12.085 kB
react-color-picker-preview
ColorArea		 50.299 kB
17.564 kB
react-color-picker-preview
ColorPicker		 32.246 kB
11.934 kB
react-color-picker-preview
ColorSlider		 41.603 kB
15.429 kB
react-combobox
Combobox (including child components)		 105.562 kB
34.52 kB
react-combobox
Dropdown (including child components)		 106.186 kB
34.462 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.236 kB
20.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 222.799 kB
64.464 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-components
react-components: entire library		 1.164 MB
291.304 kB
react-datepicker-compat
DatePicker Compat		 225.344 kB
63.793 kB
react-dialog
Dialog (including children components)		 100.513 kB
30.131 kB
react-divider
Divider		 21.354 kB
7.963 kB
react-field
Field		 23.425 kB
8.905 kB
react-image
Image		 15.386 kB
6.243 kB
react-input
Input		 28.04 kB
9.451 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.771 kB
1.643 kB
react-jsx-runtime
JSX Runtime		 4.367 kB
1.874 kB
react-label
Label		 14.697 kB
5.999 kB
react-link
Link		 17.352 kB
7.04 kB
react-list
List		 89.19 kB
26.607 kB
react-list
ListItem		 112.757 kB
33.441 kB
react-menu
Menu (including children components)		 154.074 kB
46.514 kB
react-menu
Menu (including selectable components)		 156.755 kB
47 kB
react-message-bar
MessageBar (all components)		 24.851 kB
9.276 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.506 kB
1.967 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 5.231 kB
2.296 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.714 kB
819 B
react-northstar
Accordion		 85.38 kB
26.519 kB
react-northstar
Alert		 87.435 kB
26.905 kB
react-northstar
Animation		 55.331 kB
17.83 kB
react-northstar
Attachment		 86.829 kB
26.7 kB
react-northstar
Avatar		 80.264 kB
24.633 kB
react-northstar
Box		 75.233 kB
23.813 kB
react-northstar
Breadcrumb		 79.908 kB
24.717 kB
react-northstar
Button		 83.145 kB
25.952 kB
react-northstar
Card		 82.693 kB
25.037 kB
react-northstar
Carousel		 105.17 kB
31.873 kB
react-northstar
Chat		 154.072 kB
46.878 kB
react-northstar
Checkbox		 79.792 kB
25.08 kB
react-northstar
Datepicker		 186.639 kB
56.99 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.589 kB
12.067 kB
react-northstar
Dialog		 112.046 kB
33.622 kB
react-northstar
Divider		 76.604 kB
24.135 kB
react-northstar
Dropdown		 198.196 kB
60.223 kB
react-northstar
Embed		 81.465 kB
25.425 kB
react-northstar
Flex		 47.716 kB
15.443 kB
react-northstar
Form		 92.515 kB
28.888 kB
react-northstar
Grid		 70.569 kB
22.283 kB
react-northstar
Header		 74.741 kB
23.465 kB
react-northstar
Image		 73.576 kB
23.333 kB
react-northstar
Input		 88.334 kB
27.781 kB
react-northstar
ItemLayout		 78.213 kB
24.457 kB
react-northstar
Label		 77.905 kB
24.414 kB
react-northstar
Layout		 75.378 kB
23.803 kB
react-northstar
List		 88.475 kB
27.555 kB
react-northstar
Loader		 78.601 kB
24.733 kB
react-northstar
Menu		 128.587 kB
40.738 kB
react-northstar
MenuButton		 162.993 kB
49.614 kB
react-northstar
Pill		 83.707 kB
26.069 kB
react-northstar
Popup		 135.304 kB
42.259 kB
react-northstar
Portal		 58.326 kB
18.851 kB
react-northstar
Provider		 93.129 kB
29.627 kB
react-northstar
RadioGroup		 83.27 kB
26.053 kB
react-northstar
Reaction		 77.265 kB
24.128 kB
react-northstar
Segment		 76.194 kB
23.896 kB
react-northstar
Skeleton		 77.75 kB
24.205 kB
react-northstar
Slider		 84.258 kB
26.757 kB
react-northstar
SplitButton		 178.231 kB
53.438 kB
react-northstar
Status		 76.257 kB
24.054 kB
react-northstar
SvgIcon		 36.811 kB
11.746 kB
react-northstar
Table		 80.784 kB
25.157 kB
react-northstar
Text		 74.099 kB
23.511 kB
react-northstar
TextArea		 74.233 kB
23.496 kB
react-northstar
Toolbar		 175.042 kB
52.844 kB
react-northstar
Tooltip		 109.961 kB
35.238 kB
react-northstar
Tree		 87.84 kB
27.223 kB
react-northstar
Video		 75.399 kB
23.796 kB
react-overflow
hooks only		 12.808 kB
4.819 kB
react-persona
Persona		 56.22 kB
17.704 kB
react-popover
Popover		 130.32 kB
40.699 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-positioning
usePositioning		 28.144 kB
10.046 kB
react-progress
ProgressBar		 17.11 kB
6.899 kB
react-provider
FluentProvider		 24.649 kB
8.902 kB
react-radio
Radio		 32.698 kB
10.351 kB
react-radio
RadioGroup		 15.788 kB
6.431 kB
react-select
Select		 27.758 kB
10.131 kB
react-slider
Slider		 37.546 kB
12.631 kB
react-spinbutton
SpinButton		 34.865 kB
11.639 kB
react-spinner
Spinner		 25.271 kB
8.547 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 105.112 kB
30.526 kB
react-switch
Switch		 35.345 kB
11.322 kB
react-table
DataGrid		 161.06 kB
45.718 kB
react-table
Table (Primitives only)		 42.692 kB
13.862 kB
react-table
Table as DataGrid		 131.895 kB
36.579 kB
react-table
Table (Selection only)		 70.562 kB
20.007 kB
react-table
Table (Sort only)		 69.205 kB
19.618 kB
react-tag-picker
@fluentui/react-tag-picker - package		 185.253 kB
55.693 kB
react-tags
InteractionTag		 15.225 kB
6.165 kB
react-tags
Tag		 29.098 kB
9.559 kB
react-tags
TagGroup		 82.745 kB
24.532 kB
react-teaching-popover
TeachingPopover		 91.711 kB
27.921 kB
react-text
Text - Default		 17.087 kB
6.731 kB
react-text
Text - Wrappers		 20.268 kB
7.055 kB
react-textarea
Textarea		 26.598 kB
9.761 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.835 kB
7.512 kB
react-theme
Teams: Light theme		 19.794 kB
5.602 kB
react-timepicker-compat
TimePicker		 108.551 kB
36.094 kB
react-toast
Toast (including Toaster)		 101.467 kB
30.514 kB
react-tooltip
Tooltip		 57.131 kB
19.949 kB
react-tree
FlatTree		 145.568 kB
41.82 kB
react-tree
PersonaFlatTree		 146.256 kB
41.924 kB
react-tree
PersonaTree		 142.477 kB
40.753 kB
react-tree
Tree		 141.789 kB
40.648 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 087380a45deea085c92d7d557ac841cad5c99b4b

@Anush2303 Anush2303 marked this pull request as ready for review January 15, 2025 12:16
@Anush2303 Anush2303 requested review from a team as code owners January 15, 2025 12:16
fabricteam
fabricteam reviewed Jan 15, 2025
View reviewed changes
change/@fluentui-react-charting-e1bc4943-8298-429b-b844-5503943dff7c.json
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

react-charting-AreaChart 4 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-AreaChart.Basic Dark Mode.chromium.png 794 Changed
react-charting-AreaChart.Basic.chromium.png 794 Changed
react-charting-AreaChart.Basic RTL.chromium.png 789 Changed
react-charting-AreaChart.Custom Accessibility.chromium.png 11 Changed
react-charting-DonutChart 3 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-DonutChart.Basic Dark Mode.chromium.png 582 Changed
react-charting-DonutChart.Basic RTL.chromium.png 583 Changed
react-charting-DonutChart.Basic.chromium.png 582 Changed
react-charting-HeatMapChart 3 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-HeatMapChart.Basic RTL.chromium.png 1234 Changed
react-charting-HeatMapChart.Basic Dark Mode.chromium.png 1238 Changed
react-charting-HeatMapChart.Basic.chromium.png 1238 Changed
react-charting-HorizontalBarChart 6 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-HorizontalBarChart.Basic RTL.chromium.png 859 Changed
react-charting-HorizontalBarChart.With Axis Dark Mode.chromium.png 790 Changed
react-charting-HorizontalBarChart.Basic.chromium.png 854 Changed
react-charting-HorizontalBarChart.Basic Dark Mode.chromium.png 854 Changed
react-charting-HorizontalBarChart.With Axis RTL.chromium.png 784 Changed
react-charting-HorizontalBarChart.With_Axis.chromium.png 790 Changed
react-charting-PieChart 3 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-PieChart.Basic Dark Mode.chromium.png 422 Changed
react-charting-PieChart.Basic RTL.chromium.png 419 Changed
react-charting-PieChart.Basic.chromium.png 422 Changed
react-charting-VerticalBarChart 6 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png 790 Changed
react-charting-VerticalBarChart.Basic Secondary Y Axis RTL.chromium.png 784 Changed
react-charting-VerticalBarChart.Basic Secondary Y Axis Dark Mode.chromium.png 790 Changed
react-charting-VerticalBarChart.Stacked Dark Mode.chromium.png 790 Changed
react-charting-VerticalBarChart.Stacked.chromium.png 790 Changed
react-charting-VerticalBarChart.Stacked RTL.chromium.png 784 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2025 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Jan 15, 2025
View reviewed changes
change/@fluentui-react-charting-e1bc4943-8298-429b-b844-5503943dff7c.json
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.chromium.png 48 Changed
Avatar Converged.Badge Mask RTL.chromium.png 5 Changed

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@AtishayMsft
Copy link
Contributor

Lets start following this naming convention for the PR title. https://www.conventionalcommits.org/en/v1.0.0-beta.2/

srmukher
srmukher reviewed Jan 15, 2025
View reviewed changes
packages/charts/react-charting/src/utilities/colors.ts
g: rgbLrgb1(g / 255),
b: rgbLrgb1(b / 255),
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a doc on how these numbers were derived?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I referred this https://observablehq.com/@mbostock/wcag-contrast-ratio

@Anush2303 Anush2303 changed the title Heatmap text color based on Contrast Ratio feat(react-charting): Heatmap text color based on Contrast Ratio Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srmukher srmukher srmukher left review comments

@AtishayMsft AtishayMsft AtishayMsft left review comments

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anush2303 @fabricteam @AtishayMsft @srmukher