Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(react-tree): introduces navigationMode property #33658

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jan 15, 2025

Previous Behavior

New Behavior

  1. Introduces navigationMode property
    • tree (default) - navigation as expected by tree WAI ARIA spec (+ actions interactions)
    • treegrid - navigation similar to treegrid WAI ARIA spec. pressing right arrow either opens the treeitem if it's a branch or goes from the treeitem (row) to its actions (cell).
  2. adds a story to showcase the new navigation mode.

Problems related:

  1. tabbing navigation between treeitem and actions is still valid (might be worth investigating tabster support to invalidate this navigation)

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.164 MB
291.304 kB
1.165 MB
291.509 kB
863 B
205 B
react-tree
FlatTree
145.568 kB
41.82 kB
147.093 kB
42.225 kB
1.525 kB
405 B
react-tree
PersonaFlatTree
146.256 kB
41.924 kB
147.781 kB
42.228 kB
1.525 kB
304 B
react-tree
PersonaTree
142.477 kB
40.753 kB
144.003 kB
41.074 kB
1.526 kB
321 B
react-tree
Tree
141.789 kB
40.648 kB
143.315 kB
41.07 kB
1.526 kB
422 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.236 kB
20.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.799 kB
64.464 kB
react-components
react-components: FluentProvider & webLightTheme
44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.551 kB
36.094 kB
🤖 This report was generated against 087380a45deea085c92d7d557ac841cad5c99b4b

Copy link

Pull request demo site: URL

@bsunderhus bsunderhus force-pushed the react-tree/feature--navigationMode=treegrid branch from c767926 to af1d442 Compare January 15, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants