feat: add vite sandbox template #33631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
dmytrokirpa
force-pushed
the
feat/add_vite_sandbox_template
branch
from
723bef3 to
24eb119
Compare
|
Pull request demo site: URL |
dmytrokirpa
commented
Jan 13, 2025
| @@ -0,0 +1,32 @@ | |||
| # FluentUI React v9 - Vite.js example | |||
There was a problem hiding this comment.
I'm open for suggestions for a better place than /sandbox/[template-name] to put sandbox scaffolds.
dmytrokirpa
commented
Jan 13, 2025
| "preview": "vite preview" | ||
| }, | ||
| "dependencies": { | ||
| "react": "^18.3.1", |
There was a problem hiding this comment.
The template was generated with React 18 by Vite, not sure if it's okay to use it or we should downgrade it to 17 as we here
Hotell
reviewed
Jan 14, 2025
There was a problem hiding this comment.
discussed offline - here is the gist
- we gonna proceed with this
- integration testing etc will be added later if the starter will adopt user-base in terms of bringing value to adopt fluentui
scaffolding setup tweaks
we gonna create 1 project that will be nx project and registered under yarn workspace.
something like:
- root
/starter-templates
|- /starter-templates
|- project.json ( wont contain dependencies used within starters to not add any extra dependencies within monorepo )
|- package.json ( private )
|- README.md
|- src/
|- react-components-vite/
|- .... boilerplate already present in this PR
ty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
--
New Behavior
Added a boilerplate for the Vite starter template. It can be utilized for local project bootstrapping as well as a starter for Stackblitz and CodeSandbox.
Open questions
sandbox/*be included to yarn workspaces and nx?apps/sandbox-vite-integration-tests-v9, build the sandbox project and run some cypress/playwright tests against it.react-storybook-addon-export-to-sandboxRelated Issue(s)