fix(docs): useIsOverflow unsubscribe if ref changes #33630
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tomatic unsub from observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
While the previous examle is working fine for the example use-case, the hook might need adjustment when used in real world usecase.
IF: element to observe changes, eg. when rendered in different place (e.g. wrapped contitionally)
IT WILL: Evaluate the overflow based on the not mounted element. It as well does not observe any changes to the new Element.
BECAUSE: This hook stores a JS ref to the element. RO will only automaticaly unobserve if no JS ref to the element exists (see w3c/csswg-drafts#5155 (comment)).
New Behavior
Unobserve element if needed and observe new element, calculate overflow based on new element.
Related Issue(s)