Adding fallback and fixes for test app crashes for 12 schema data #33624
+84
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…microsoft/fluentui into users/srmukher/FixCrashesPlotly
srmukher
force-pushed
the
users/srmukher/FixCrashesPlotly
branch
from
45d521e to
bcb80ef
Compare
|
Pull request demo site: URL |
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchema.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
…microsoft/fluentui into users/srmukher/FixCrashesPlotly
…microsoft/fluentui into users/srmukher/FixCrashesPlotly
AtishayMsft
reviewed
Jan 15, 2025
| /> | ||
| ); | ||
| }; | ||
| return checkAndRenderChart(renderLineChartJsx); |
AtishayMsft
reviewed
Jan 15, 2025
| fallbackVSBC = true; | ||
| return ( | ||
| <VerticalStackedBarChart | ||
| {...transformPlotlyJsonToVSBCProps(plotlySchema, colorMap, isDarkTheme, fallbackVSBC)} |
AtishayMsft
reviewed
Jan 15, 2025
| onChange: onActiveLegendsChange, | ||
| canSelectMultipleLegends: true, | ||
| selectedLegends: activeLegends, | ||
| }, |
There was a problem hiding this comment.
legendProps={multiSelectLegendProps}
AtishayMsft
reviewed
Jan 15, 2025
| @@ -212,7 +214,7 @@ export const transformPlotlyJsonToVSBCProps = ( | |||
| } | |||
| const legend: string = getLegend(series, index1); | |||
| const yVal: number = (series.y?.[index2] as number) ?? 0; | |||
| if (series.type === 'bar' || series.type === 'scatter') { | |||
| if (series.type === 'bar' || series.type === 'scatter' || fallbackVSBC) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR https://github.com/microsoft/fluentui/pull/33542/files?diff=split&w=0
Fixes for test app crashes for 12 schema data
Fixed schema data numbers 84, 85, 88, 91, 92, 93, 99, 100, 101, 102, 103, 107