-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounded Tick Values in Declarative charts #33619
Open
Anush2303
wants to merge
6
commits into
user/atisjai/stronglyTypePlotly
Choose a base branch
from
usr/agupta/declarative/roundedTicks
base: user/atisjai/stronglyTypePlotly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rounded Tick Values in Declarative charts #33619
Anush2303
wants to merge
6
commits into
user/atisjai/stronglyTypePlotly
from
usr/agupta/declarative/roundedTicks
+1,243
−1,205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
Pull request demo site: URL |
fabricteam
reviewed
Jan 13, 2025
change/@fluentui-react-charting-ea816697-9232-4117-8d82-fd6fbacb2acb.json
Show resolved
Hide resolved
Anush2303
changed the base branch from
master
to
user/atisjai/stronglyTypePlotly
January 13, 2025 06:36
…ative/roundedTicks
AtishayMsft
reviewed
Jan 13, 2025
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Outdated
Show resolved
Hide resolved
srmukher
reviewed
Jan 13, 2025
@Anush2303 you can add few tests for the changes |
…ative/roundedTicks
Okay sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Related Issue(s)