chore: replace deprecation eslint plugin in favor of ts-eslint/no-deprecated #33602
+954
−823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
chore/eslint-migrate-to-ts-no-deprecated
branch
from
14abbfb to
46fdc35
Compare
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jan 9, 2025
| @@ -4,7 +4,14 @@ | |||
| "rules": { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 1 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 13 | Changed |
|
finally this is happening, please measure the perf ( AFAIR the new plugin should be significantly faster ) ty |
mainframev
force-pushed
the
chore/eslint-migrate-to-ts-no-deprecated
branch
2 times, most recently
from
6655f28 to
fc5293e
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
mainframev
force-pushed
the
chore/eslint-migrate-to-ts-no-deprecated
branch
from
d19fbf4 to
0bddbec
Compare
mainframev
requested review from
a team,
dzearing,
behowell,
khmakoto,
ThomasMichon,
Jahnp,
spmonahan,
tomi-msft,
dmytrokirpa and
phkuo
as code owners
Hotell
reviewed
Jan 14, 2025
apps/chart-docsite/.eslintrc.json
Outdated
| "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }] | ||
| } | ||
| }, | ||
| "overrides": [ |
There was a problem hiding this comment.
why was this moved to overrides ?
There was a problem hiding this comment.
overlooked, fixed, thank you
layershifter
approved these changes
Jan 14, 2025
mainframev
force-pushed
the
chore/eslint-migrate-to-ts-no-deprecated
branch
from
0bddbec to
828f854
Compare
fabricteam
reviewed
Jan 15, 2025
| @@ -4,7 +4,7 @@ | |||
| "rules": { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-deprecation is archived and no longer maintained. It's recommended to migrate to @typescript-eslint/no-deprecated before migrating to eslint v9.
perf for rule tested locally (nx run react:lint --skip-nx-cache):
~ 12% faster 🚀
Related Issue(s)
Partially implements #30334