Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-link): support Enter and Space keys interaction, if rendered as span #33587

Merged

Conversation

mainframev
Copy link
Contributor

@mainframev mainframev commented Jan 8, 2025

Previous Behavior

Currently keyboard interaction via Enter and Space is not possible, when Link is rendered as span.

New Behavior

Added explicit handling of Enter and Space 🧢

Related Issue(s)

Copy link

github-actions bot commented Jan 8, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.164 MB
291.232 kB
1.164 MB
291.265 kB
100 B
33 B
react-link
Link
17.326 kB
7.032 kB
17.426 kB
7.068 kB
100 B
36 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-breadcrumb
@fluentui/react-breadcrumb - package
114.291 kB
31.695 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.703 kB
64.42 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-message-bar
MessageBar (all components)
24.825 kB
9.267 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.525 kB
36.087 kB
🤖 This report was generated against befe9020d9198ff7f3d7e9042fc2c249c874b050

Copy link

github-actions bot commented Jan 8, 2025

Pull request demo site: URL

@mainframev mainframev marked this pull request as ready for review January 8, 2025 19:36
@mainframev mainframev requested a review from a team as a code owner January 8, 2025 19:36
@mainframev mainframev force-pushed the link/support-enter-space-with-span branch 2 times, most recently from 335ef30 to 9da4ae9 Compare January 10, 2025 17:00
@mainframev mainframev force-pushed the link/support-enter-space-with-span branch from 9da4ae9 to d3a911d Compare January 10, 2025 19:19
@mainframev mainframev requested a review from Hotell January 13, 2025 10:41
@mainframev mainframev merged commit 928fdce into microsoft:master Jan 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Enter key or space bar does not call the onclick handler on Link component when used as span
4 participants