Enable 'tozeroy' mode for Area Charts #33581
Conversation
📊 Bundle size report✅ No changes found |
srmukher
force-pushed
the
users/srmukher/zero_to_y
branch
from
f54f284 to
43263f2
Compare
srmukher
force-pushed
the
users/srmukher/zero_to_y
branch
2 times, most recently
from
75a3500 to
7fbe2c1
Compare
srmukher
force-pushed
the
users/srmukher/zero_to_y
branch
from
7fbe2c1 to
561c69e
Compare
|
Pull request demo site: URL |
packages/charts/react-charting/src/components/AreaChart/AreaChart.types.ts
Outdated
Show resolved
Hide resolved
packages/charts/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
packages/charts/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
packages/charts/react-charting/src/components/AreaChart/AreaChart.base.tsx
Show resolved
Hide resolved
packages/charts/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
| currentStack.push({ | ||
| values: d, | ||
| currentLayer.push({ | ||
| values: this.props.mode === AreaChartModes.toZeroY ? [0, d[1]] : d, |
There was a problem hiding this comment.
add a snapshot test for this change
packages/charts/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
packages/charts/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
The overlapping color is not coming correctly. |
This is because the layers have different colors and one over the other. Clicking each legend individually gives the individual colors correctly. Similar is for plotly: |
|
fixed as discussed offline
this needs to be fixed |
🕵 fluentuiv8 No visual regressions between this PR and main |
|
Can you share a screenshot of the implementation |
already updated the description with the screenshot |
Not clear in the description. It has percentage and not absolute values |
|
Enable 'tozeroy' mode for Area Charts