Fix shellcheck error SC2317 & failing test

[wxtim]

No description provided.

[oliver-sanders]

Seems like a reasonable check: https://www.shellcheck.net/wiki/SC2317

What's the bizz?

[wxtim]

Seems like a reasonable check: https://www.shellcheck.net/wiki/SC2317

What's the bizz?

I don't want to change rose-mpi-launch - and the case statement looks valid: It's metomi/rose/scripts/rose-mpi-launch and it looks like it's the end of each --help case statement. It seems legit - but I'm not at all clear whether it is given the case statement context.

[MetRonnie]

The shellcheck lint should be addressed like in cylc/cylc-flow#6408. But happy to punt to an issue for after the release

[oliver-sanders]

I don't want to change rose-mpi-launch - and the case statement looks valid

We can ignore the one particular instance rather than ignoring the entire code globally.

[MetRonnie]

1 test failing: t/rose-task-run/06-app-prune-iso.t

[oliver-sanders]

the case statement looks valid:

I think it's the colon character that shellcheck is objecting to, and I think that's a valid objection:

https://stackoverflow.com/a/3224910

[wxtim]

the case statement looks valid:

I think it's the colon character that shellcheck is objecting to, and I think that's a valid objection:

https://stackoverflow.com/a/3224910

Came to this conclusion independently. Just pushing.

[oliver-sanders]

1 test failing: t/rose-task-run/06-app-prune-iso.t

confirmed locally:

cylc.flow.exceptions.GraphParseError: Opposite outputs my_task_1:succeeded and my_task_1:failed must both be optional if both are used (via family trigger defaults

Easy fix.

[oliver-sanders]

This'll do it:

diff --git a/t/rose-task-run/06-app-prune-iso/flow.cylc b/t/rose-task-run/06-app-prune-iso/flow.cylc
index d720a8dd0..f9abceb49 100644
--- a/t/rose-task-run/06-app-prune-iso/flow.cylc
+++ b/t/rose-task-run/06-app-prune-iso/flow.cylc
@@ -16,7 +16,7 @@
 {% if HOST != 'localhost' %}
                 my_task_2
 {% endif %}
-                WARM[-PT12H]:finish-all => rose_prune
+                WARM[-PT12H]:succeed-all => rose_prune
             """
 
 [runtime]

[wxtim]

Does this PR want to be against the release branch or master?

[oliver-sanders]

Either, only the changelog and version number differ.

[oliver-sanders]

Gotta do this for the other branches too.

[oliver-sanders]

(I had no idea : was an alias for true)

[wxtim]

Only the other branch with an exit in it.

[oliver-sanders]

I cannot reproduce the Mac OS test failures locally (12.7)

$ rtb t/rose-task-run/13-app-arch-cmd-out.t t/rose-task-run/30-app-arch-opt-source.t t/rose-app-run/05-file.t t/rose-task-env/02-360day-cycling.t 
t/rose-task-run/13-app-arch-cmd-out.t ..... ok                          
t/rose-task-run/30-app-arch-opt-source.t .. ok                          
t/rose-app-run/05-file.t .................. ok                          
t/rose-task-env/02-360day-cycling.t ....... ok   
All tests successful.

Possibly just a CI setup issue.