🌱 Add support for IRSO in e2e pipeline #950
Conversation
metal3-io-bot
added
the
size/XS
metal3-io-bot
added
the
approved
mquhuy
force-pushed
the
mquhuy/add-support-for-irso
branch
from
da331b4 to
5811ad6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
size/S
This adds IRSO param for E2E pipeline Signed-off-by: Huy Mai <[email protected]>
mquhuy
force-pushed
the
mquhuy/add-support-for-irso
branch
from
5811ad6 to
45e6642
Compare
metal3-io-bot
added
size/M
| @@ -48,3 +48,16 @@ presubmits: | |||
| value: "/" | |||
| image: ghcr.io/yannh/kubeconform:v0.6.7-alpine@sha256:824e0c248809e4b2da2a768b16b107cf17ada88a89ec6aa6050e566ba93ebbc6 | |||
| imagePullPolicy: Always | |||
| # name: metal3-dev-env-integration-test-{image_os}-main | |||
| - name: metal3-dev-env-integration-test-ubuntu-main | |||
There was a problem hiding this comment.
Shouldn't these jobs set USE_IRSO?
There was a problem hiding this comment.
Afaiu USE_IRSO should be set from jjb side, haven't seen any jenkins jobs setting its own env var in prow. But I'm not a prow pro 😄 Maybe @lentzi90 could help answering this?
There was a problem hiding this comment.
Yes that should come from jjb. Prow will only trigger the jobs with whatever defaults they have
|
/test metal3-ubuntu-e2e-integration-test-main |
|
@mquhuy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mquhuy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This adds IRSO param for E2E pipeline