Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vc/fs 1864 #153

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Vc/fs 1864 #153

merged 7 commits into from
Dec 16, 2024

Conversation

DoctorVin
Copy link
Contributor

Most importantly we change cmd/list/firmware_set.go to remove the search criteria for latest-true,default=true which was applied by default.

Side effects of this work bring mctl up to date with Equinix versions of bmc-common and an update to rivets/v2

@DoctorVin DoctorVin marked this pull request as ready for review December 11, 2024 17:02
ofaurax
ofaurax previously requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ofaurax ofaurax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor and model should be optional, and even independent (= provide vendor without model)

docs/mctl_list_firmware-set.md Show resolved Hide resolved
@DoctorVin DoctorVin dismissed ofaurax’s stale review December 16, 2024 15:45

answered the comments, no reply

@DoctorVin DoctorVin merged commit d427781 into main Dec 16, 2024
9 checks passed
@DoctorVin DoctorVin deleted the vc/fs-1864 branch December 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeefreak101 coffeefreak101 coffeefreak101 approved these changes

@ofaurax ofaurax ofaurax left review comments

@jakeschuurmans jakeschuurmans Awaiting requested review from jakeschuurmans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DoctorVin @ofaurax @coffeefreak101