add grpc health methods to runtime. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the standard grpc_health_v1 service to the iamruntime package. This provides support for checking health on the runtime ensuring the runtime is healthy before use. BEHAVIOR CHANGE: With the introduction of the health check service, NewClient has been updated to block, waiting for the service to report healthy. NewClient will block for up to 10 seconds before reporting that the runtime is not healthy. This behavior change ensures clients are making requests against a healthy runtime. To disable this new behavior `NewClient` must be updated to `NewClientWithoutWait`. Alternatively setting the environment variable `IAMRUNTIME_NEW_CLIENT_WAIT_TIMEOUT` to 0 will disable this new behavior. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
add-health-service
branch
from
5528b51 to
2f3de64
Compare
adammohammed
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the standard grpc_health_v1 service to the iamruntime package. This provides support for checking health on the runtime ensuring the runtime is healthy before use.
BEHAVIOR CHANGE:
With the introduction of the health check service, NewClient has been updated to block, waiting for the service to report healthy. NewClient will block for up to 10 seconds before reporting that the runtime is not healthy.
If the runtime reports the health service is unimplemented, it is assumed the runtime is ready and unblocks the request.
This behavior change ensures clients are making requests against a healthy runtime. To disable this new behavior
NewClientmust be updated toNewClientWithoutWait. Alternatively setting the environment variableIAMRUNTIME_NEW_CLIENT_WAIT_TIMEOUTto 0 will disable this new behavior.