api/v1/orc: taskPublish handler to return 404 on condition not found

metal-toolbox · Jul 31, 2024 · e231e65 · e231e65
1 parent 9b19e5d
commit e231e65
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/api/v1/orchestrator/routes/handlers.go b/pkg/api/v1/orchestrator/routes/handlers.go
@@ -296,7 +296,7 @@ func (r *Routes) taskPublish(c *gin.Context) (int, *v1types.ServerResponse) {
 	activeCond, err := r.repository.GetActiveCondition(ctx, serverID)
 	if err != nil {
 		if errors.Is(err, store.ErrConditionNotFound) {
-			return http.StatusBadRequest, &v1types.ServerResponse{
+			return http.StatusNotFound, &v1types.ServerResponse{
 				Message: err.Error(),
 			}
 		}

diff --git a/pkg/api/v1/orchestrator/routes/handlers_test.go b/pkg/api/v1/orchestrator/routes/handlers_test.go
@@ -578,7 +578,7 @@ func TestTaskPublish(t *testing.T) {
 				return request
 			},
 			assertResponse: func(t *testing.T, r *httptest.ResponseRecorder) {
-				assert.Equal(t, http.StatusBadRequest, r.Code)
+				assert.Equal(t, http.StatusNotFound, r.Code)
 				assert.Contains(t, string(asBytes(t, r.Body)), "expected an active condition: condition not found")
 			},
 		},