This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
[FS-1310]Initialize the client library #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alva8756
force-pushed
the
add-client-api
branch
from
c5c1838 to
c495527
Compare
Alva8756
force-pushed
the
add-client-api
branch
from
c495527 to
cbc6e8a
Compare
DoctorVin
suggested changes
Mar 13, 2024
| return client, nil | ||
| } | ||
|
|
||
| func (c componentInventoryClient) GetServerComponents(ctx context.Context, serverID string) (ServerComponents, error) { |
There was a problem hiding this comment.
This is fine for the current iteration. I wonder if there is something in bmc-toolbox/common that would be better than rivets. I'll look into that today.
There was a problem hiding this comment.
Thanks!
It looks common.Device can also fit here. Do we want to discard rivets in favor of bmc-toolbox/common?
If this is the case, I will add an util library for converting fleetdb.ServerComponent to common.Device
Alva8756
force-pushed
the
add-client-api
branch
from
7f91e28 to
a39b5ce
Compare
Alva8756
force-pushed
the
add-client-api
branch
from
a39b5ce to
4dc9d93
Compare
DoctorVin
approved these changes
Mar 14, 2024
| @@ -52,6 +52,11 @@ load-sandbox: | |||
| @cp helm/configmap.yaml "${SANDBOX_TEMPLATE_DIR}/cis-configmap.yaml" | |||
| @echo "Be sure to do a helm (re)load to get the service started" | |||
|
|
|||
| ## generate mock client | |||
| gen-client-mock: | |||
Alva8756
changed the title
DoctorVin
added a commit
that referenced
this pull request
May 1, 2024
* add README * add a client API to fetch server components * add inventory api placeholder functions Add in API endpoints and the beginning of handler functions for converting incoming common.Device objects into FleetDB server records. * Initialize the client library (#6) * initialize the client library * refactor minor * internal fleetdb outline (#9) * Move types ownership to alloy (#11) * fix panic when there's no response (#12) * Convert Alloy Data to Rivets.Server (#16) * type converter * typo * Forward Inventory to FleetDB (#19) * forward inventory to fleetdb * cleanup code * rebase (#20) * use bmc-toolbox component types (#21) * update dependencies --------- Co-authored-by: Alva Zhang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize the client library interface