Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional Kubernetes resource types in default configuration #363

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

devhindo
Copy link
Member

@devhindo devhindo commented Jan 6, 2025

fixes: #362

@devhindo devhindo requested a review from leecalcote January 6, 2025 14:40
@palSagnik
Copy link
Contributor

@leecalcote a doubt from my side if you notice an example such as the resource for statefulset we use statefulsets.v1.apps even though here it says different https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#statefulset-v1-apps.

But we follow the same for some of them like csidriver csidriver.v1.storage.k8s.io as added by @devhindo following the docs https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#csidriver-v1-storage-k8s-io

Any reason why this is different? Is this is a trivial knowledge issue?

@leecalcote
Copy link
Member

@leecalcote a doubt from my side if you notice an example such as the resource for statefulset we use statefulsets.v1.apps even though here it says different https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#statefulset-v1-apps.

Specifically what is different, @palSagnik?

@leecalcote
Copy link
Member

@palSagnik be sure to use v1.32 API docs. The 1.29 api docs were published a couple of years ago.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @devhindo. LGTM

@palSagnik, @devhindo used list of K8s resources from the Meshery Integrations spreadsheet.

@palSagnik
Copy link
Contributor

@leecalcote a doubt from my side if you notice an example such as the resource for statefulset we use statefulsets.v1.apps even though here it says different https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#statefulset-v1-apps.

Specifically what is different, @palSagnik?

Ok I realised I was checking the v1.29 docs, my bad.

@leecalcote leecalcote merged commit 7a3a606 into meshery:master Jan 9, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Static List of Default Resource Discovery Configuration
3 participants