-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle analytical mode in community_detection during parallel changes #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think good job in general, take care about duplication please :)
cpp/community_detection_module/community_detection_online_module.cpp
Outdated
Show resolved
Hide resolved
cpp/community_detection_module/community_detection_online_module.cpp
Outdated
Show resolved
Hide resolved
cpp/community_detection_module/community_detection_online_module.cpp
Outdated
Show resolved
Hide resolved
cpp/betweenness_centrality_module/betweenness_centrality_module.cpp
Outdated
Show resolved
Hide resolved
And you have build errors, please take care about that before requesting review again. For next time tip: it is better to request review after build errors are fixed since it gives reviewer more confidence that hey this is good and meaningful fix without negative impact on the rest of the system |
cpp/community_detection_module/community_detection_online_module.cpp
Outdated
Show resolved
Hide resolved
My initial idea was to make body of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I can't approve the PR since I'm author.
…mage into handle-analytical-mode
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@vpavicic As this PR is the MAGE side of memgraph/memgraph#1395, they are covered by the same docs PR (memgraph/documentation#361) and should both be linked in the same release note. |
Description
NB: PR taken over by @antepusic; connected with memgraph/memgraph#1395
Since there are no ACID guarantees in analytical storage mode, the graph may get modified by parallel transactions while the user’s query is running. Query procedures and functions that return graph elements (nodes and relationships) should be robust to the deletion of graph elements, and this PR aims to fix that.
This PR contains changes to query modules that ensure the intended behavior:
Merge commit message:
Pull request type
Related issues
Resolves memgraph/memgraph#1036 (together with memgraph/memgraph#1395)
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################