[E-merge < T674] Implement merge.node #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpintaric55334
added
status: ready
imilinovic
added
status: change
mpintaric55334
added
status: ready
cpp/merge_module/algorithm/merge.cpp
Outdated
Comment on lines
43
to
45
| auto identProp = arguments[1].ValueMap(); | ||
| auto createProp = arguments[2].ValueMap(); | ||
| auto matchProp = arguments[3].ValueMap(); |
There was a problem hiding this comment.
Same comment about namings as below, use _ between name parts
antoniofilipovic
suggested changes
Oct 23, 2023
antoniofilipovic
added
status: change
mpintaric55334
added
status: ready
16 tasks
antoniofilipovic
approved these changes
Oct 25, 2023
antoniofilipovic
added
status: ship it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly explain the changes you made here.
Pull request type
Related issues
Delete if this PR doesn't resolve any issues. Link the issue if it does.
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################