Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E-algo < T581] Implement algo.cover #389

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[E-algo < T581] Implement algo.cover #389

merged 3 commits into from
Oct 23, 2023

Conversation

mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@mpintaric55334 mpintaric55334 added status: ready PR is ready for review Docs needed Docs needed labels Oct 11, 2023
@mpintaric55334 mpintaric55334 added this to the 1.12.0 milestone Oct 11, 2023
@mpintaric55334 mpintaric55334 self-assigned this Oct 11, 2023
antoniofilipovic
antoniofilipovic approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Oct 16, 2023
@antoniofilipovic
Copy link
Contributor

@mpintaric55334 don't forget to update description and ping Vlasta

imilinovic
imilinovic requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

@imilinovic imilinovic added status: change PR reviewed - needs changes and removed status: ship it PR approved labels Oct 16, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Oct 22, 2023
@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Oct 23, 2023
imilinovic
imilinovic approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@antoniofilipovic antoniofilipovic merged commit 8f73d16 into E-add-algo-module Oct 23, 2023
2 checks passed
@antoniofilipovic antoniofilipovic deleted the T581-MAGE-cover branch October 23, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

@imilinovic imilinovic imilinovic approved these changes

Assignees

@mpintaric55334 mpintaric55334

Labels
Docs needed Docs needed status: ship it PR approved
Projects
mage
Status: Done
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mpintaric55334 @antoniofilipovic @imilinovic