Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFTPGo configuration #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SFTPGo configuration #122

wants to merge 3 commits into from

Conversation

enggnr
Copy link
Contributor

@enggnr enggnr commented Nov 24, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This change adds features to SFTPGo default configuration - added branding, LDAP integration, etc.

  • What is the current behavior? (You can also link to an open issue here)
    Default configuration was provided, which has now been enhanced.

  • Other information:
    Fixes Create Optimized SFTPGo Configuration #80.

Copy link

github-actions bot commented Nov 24, 2023

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 8c466ab and f3e9cd0 commits.
Files selected (4)
  • home/.chezmoiscripts/universal/run_onchange_after_57-netdata.sh.tmpl (1)
  • home/dot_local/etc/cloudflared/config.yml.tmpl (2)
  • home/dot_local/etc/sftpgo/banner (1)
  • home/dot_local/etc/sftpgo/sftpgo.json.tmpl (5)
Files ignored due to filter (4)
  • home/dot_local/etc/sftpgo/branding/favicon.ico
  • home/dot_local/etc/sftpgo/branding/login_image.png
  • home/dot_local/etc/sftpgo/branding/logo.png
  • software.yml
Files not summarized due to errors (4)
  • home/.chezmoiscripts/universal/run_onchange_after_57-netdata.sh.tmpl (nothing obtained from openai)
  • home/dot_local/etc/sftpgo/banner (nothing obtained from openai)
  • home/dot_local/etc/sftpgo/sftpgo.json.tmpl (nothing obtained from openai)
  • home/dot_local/etc/cloudflared/config.yml.tmpl (nothing obtained from openai)
Files not reviewed due to errors (4)
  • home/.chezmoiscripts/universal/run_onchange_after_57-netdata.sh.tmpl (no response)
  • home/dot_local/etc/sftpgo/sftpgo.json.tmpl (no response)
  • home/dot_local/etc/sftpgo/banner (no response)
  • home/dot_local/etc/cloudflared/config.yml.tmpl (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link
Contributor

@ProfessorManhattan ProfessorManhattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @enggnr --- great commit, love that you added JumpCloud support and went through some of the options like the banner and image paths.

Can you add documentation to the chart in docs/customization/secrets.md that explains how to get the JUMPBINDDN etc.?

@ProfessorManhattan
Copy link
Contributor

I already manually merged this FYI @enggnr --- still need the documentation on how to acquire the variables though

@enggnr
Copy link
Contributor Author

enggnr commented Dec 28, 2023

Hi @ProfessorManhattan, I have added the documentation and included the Icon to the branch. These files are needed for the POST script to complete successfully. Please include these files (along with their parent directory) when merging.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 15d4922 and dc43100 commits.
Files selected (3)
  • docs/customization/secrets.md (3)
  • home/dot_local/etc/cloudflared/config.yml.tmpl (1)
  • home/dot_local/etc/sftpgo/banner (1)
Files ignored due to filter (4)
  • home/dot_local/etc/sftpgo/branding/favicon.ico
  • home/dot_local/etc/sftpgo/branding/login_image.png
  • home/dot_local/etc/sftpgo/branding/logo.png
  • software.yml
Files not summarized due to errors (3)
  • home/dot_local/etc/cloudflared/config.yml.tmpl (nothing obtained from openai)
  • home/dot_local/etc/sftpgo/banner (nothing obtained from openai)
  • docs/customization/secrets.md (nothing obtained from openai)
Files not reviewed due to errors (3)
  • home/dot_local/etc/sftpgo/banner (no response)
  • home/dot_local/etc/cloudflared/config.yml.tmpl (no response)
  • docs/customization/secrets.md (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@enggnr enggnr assigned ProfessorManhattan and unassigned enggnr Dec 28, 2023
@ProfessorManhattan
Copy link
Contributor

Hey @enggnr --- can you please use the already included logo branding assets located at home/dot_local/etc/branding? Actually, nevermind I just did this. But can you please update the software.yml file to include a script that will install the github: entry? You can leave the github: entry since I might introduce the ability to download from releases. However, for now add something like:

auth-plugin:
  script: |
     curl xyz.com > /usr/local/bin/xyz

Make sure to download the appropriate release if there are multiple platforms etc.

Also, for now, going forward, you can commit directly to master for simple changes to the software.yml or to the docs. However, do please keep me well-informed on what direct commits you're adding.

This might make it easier to debug as well. I don't really follow the traditional git commit / PR model.

@enggnr
Copy link
Contributor Author

enggnr commented Apr 27, 2024

Added script based installation of auth-plugin 9b541a0.

@enggnr enggnr assigned ProfessorManhattan and unassigned enggnr Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Optimized SFTPGo Configuration
2 participants