-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFTPGo configuration #122
base: master
Are you sure you want to change the base?
SFTPGo configuration #122
Conversation
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (4)
- home/.chezmoiscripts/universal/run_onchange_after_57-netdata.sh.tmpl (1)
- home/dot_local/etc/cloudflared/config.yml.tmpl (2)
- home/dot_local/etc/sftpgo/banner (1)
- home/dot_local/etc/sftpgo/sftpgo.json.tmpl (5)
Files ignored due to filter (4)
- home/dot_local/etc/sftpgo/branding/favicon.ico
- home/dot_local/etc/sftpgo/branding/login_image.png
- home/dot_local/etc/sftpgo/branding/logo.png
- software.yml
Files not summarized due to errors (4)
- home/.chezmoiscripts/universal/run_onchange_after_57-netdata.sh.tmpl (nothing obtained from openai)
- home/dot_local/etc/sftpgo/banner (nothing obtained from openai)
- home/dot_local/etc/sftpgo/sftpgo.json.tmpl (nothing obtained from openai)
- home/dot_local/etc/cloudflared/config.yml.tmpl (nothing obtained from openai)
Files not reviewed due to errors (4)
- home/.chezmoiscripts/universal/run_onchange_after_57-netdata.sh.tmpl (no response)
- home/dot_local/etc/sftpgo/sftpgo.json.tmpl (no response)
- home/dot_local/etc/sftpgo/banner (no response)
- home/dot_local/etc/cloudflared/config.yml.tmpl (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitai
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignore
anywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @enggnr --- great commit, love that you added JumpCloud support and went through some of the options like the banner and image paths.
Can you add documentation to the chart in docs/customization/secrets.md
that explains how to get the JUMPBINDDN etc.?
I already manually merged this FYI @enggnr --- still need the documentation on how to acquire the variables though |
Hi @ProfessorManhattan, I have added the documentation and included the Icon to the branch. These files are needed for the POST script to complete successfully. Please include these files (along with their parent directory) when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (3)
- docs/customization/secrets.md (3)
- home/dot_local/etc/cloudflared/config.yml.tmpl (1)
- home/dot_local/etc/sftpgo/banner (1)
Files ignored due to filter (4)
- home/dot_local/etc/sftpgo/branding/favicon.ico
- home/dot_local/etc/sftpgo/branding/login_image.png
- home/dot_local/etc/sftpgo/branding/logo.png
- software.yml
Files not summarized due to errors (3)
- home/dot_local/etc/cloudflared/config.yml.tmpl (nothing obtained from openai)
- home/dot_local/etc/sftpgo/banner (nothing obtained from openai)
- docs/customization/secrets.md (nothing obtained from openai)
Files not reviewed due to errors (3)
- home/dot_local/etc/sftpgo/banner (no response)
- home/dot_local/etc/cloudflared/config.yml.tmpl (no response)
- docs/customization/secrets.md (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitai
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignore
anywhere in the PR description to pause further reviews from the bot.
Hey @enggnr --- can you please use the already included logo branding assets located at
Make sure to download the appropriate release if there are multiple platforms etc. Also, for now, going forward, you can commit directly to master for simple changes to the This might make it easier to debug as well. I don't really follow the traditional git commit / PR model. |
Added script based installation of |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This change adds features to SFTPGo default configuration - added branding, LDAP integration, etc.
What is the current behavior? (You can also link to an open issue here)
Default configuration was provided, which has now been enhanced.
Other information:
Fixes Create Optimized SFTPGo Configuration #80.