-
Notifications
You must be signed in to change notification settings - Fork 300
Commit
Remove createJSModules
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,11 +20,6 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte | |
return Collections.emptyList(); | ||
} | ||
|
||
@Override | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
maxs15
Author
Owner
|
||
public List<Class<? extends JavaScriptModule>> createJSModules() { | ||
return Collections.emptyList(); | ||
} | ||
|
||
@Override | ||
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) { | ||
List<ViewManager> list = new ArrayList<>(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,5 +28,6 @@ | |
} | ||
}, | ||
"dependencies": { | ||
"prop-types": "^15.5.8" | ||
} | ||
} |
@maxs15 @ground5hark This will have issue with backward compatibility. Why not just remove
@Override
to have support for RN 0.46.x as well as 0.47.0.