Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogP calculations for 50k dataset #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LogP calculations for 50k dataset #13

wants to merge 1 commit into from

Conversation

tantrev
Copy link

@tantrev tantrev commented Nov 4, 2016

LogP calculations for the 50k dataset. Same order as original SMILES file.

@maxhodak
Copy link
Owner

maxhodak commented Nov 6, 2016

What's the origin of these? Are these measured logPs based on looking up the SMILES? Or cLogP from rdkit? Something else?

@tantrev
Copy link
Author

tantrev commented Nov 6, 2016

Sorry, I should have specified. The LogP values were generated using ChemAxon's "generatemd" program from this repository's "smiles_50k.h5" file.

@maxhodak
Copy link
Owner

maxhodak commented Nov 6, 2016

What would be really great is if you could alter the smiles_50k.h5 file to include a clogp column with this data indexed to the right rows, instead of including this separately as a txt file. Then it would work with the --property_column parameter on the preprocessing script and the rest of the tooling here.

@hsiaoyi0504
Copy link
Contributor

hsiaoyi0504 commented Nov 9, 2016

I am curious about if it will be an issue to include data generated from ChemAxon. I mean any license issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants