Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Scroll indicator #12205

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Rework Scroll indicator #12205

merged 2 commits into from
Dec 16, 2024

Conversation

DonLakeFlyer
Copy link
Contributor

* No longer a margin on edge anchoring
* Slightly larger, based on font widths
* Single control which cleans up duplication
@DonLakeFlyer
Copy link
Contributor Author

@DieBorr Can you look at this one as well to see what you think?

@DieBorr
Copy link
Contributor

DieBorr commented Dec 14, 2024

It's fine, the only downside is what we discussed earlier, in objects that have elements near the right side the vertical flickable can overlap a little bit, for example in the guided value slider this is what happens, for me is not a big deal, but the truth is that is there is a small overlap, if you want I can check it on my own how to solve this, but probably I will need to make a logic in the flickable itself just for this specific case:
Screenshot from 2024-12-14 23-50-55

I have also made a pull request related with indentation. #12208

@DonLakeFlyer
Copy link
Contributor Author

That's an image using the old slider code. The new slider code has a margin on the right.

@DieBorr
Copy link
Contributor

DieBorr commented Dec 15, 2024

That's an image using the old slider code. The new slider code has a margin on the right.

Sorry for the mistake, will take a look tomorrow!

@DonLakeFlyer DonLakeFlyer merged commit 938cea6 into master Dec 16, 2024
8 checks passed
@DonLakeFlyer DonLakeFlyer deleted the ScrollIndicator branch December 16, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants