CMake: Improve GStreamer Inclusion #11806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
10 times, most recently
from
103e8d8 to
9db942b
Compare
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
15 times, most recently
from
8686864 to
e297efc
Compare
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
3 times, most recently
from
455a835 to
d0deb87
Compare
|
That's great. I tried it out. It works perfectly |
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
from
c370e37 to
517f18c
Compare
DonLakeFlyer
reviewed
Sep 6, 2024
| @@ -15,6 +7,16 @@ qt_add_library(VideoManager STATIC | |||
| VideoManager.h | |||
| ) | |||
|
|
|||
| # option(QGC_ENABLE_VIDEOSTREAMING "Enable video streaming" ON) | |||
There was a problem hiding this comment.
Why leave in commented out?
| qgcputenv("GST_PLUGIN_SYSTEM_PATH", "/usr/lib/x86_64-linux-gnu", "/gstreamer-1.0"); | ||
| qgcputenv("GST_PLUGIN_PATH_1_0", currentDir, "../lib"); | ||
| qgcputenv("GST_PLUGIN_PATH", currentDir, "../lib"); | ||
| // const QString currentDir = QCoreApplication::applicationDirPath(); |
There was a problem hiding this comment.
Why leave in commented out?
There was a problem hiding this comment.
I was still messing with those when I had time. I'm having a hard time getting it perfect for all systems
| target_compile_definitions(GStreamerReceiver PUBLIC QGC_GST_STREAMING) | ||
| if(CMAKE_BUILD_TYPE STREQUAL "Release") | ||
| if(MACOS AND CMAKE_BUILD_TYPE STREQUAL "Release") |
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
10 times, most recently
from
95d0178 to
3d44849
Compare
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
12 times, most recently
from
c04e92d to
eed6a8c
Compare
HTRamsey
force-pushed
the
dev-cmake-gstreamer
branch
from
eed6a8c to
5180f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly better method of handling GStreamer in CMake