Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: UI fixes #11796

Closed
wants to merge 4 commits into from
Closed

WIP: UI fixes #11796

wants to merge 4 commits into from

Conversation

gillamkid
Copy link
Contributor

@gillamkid gillamkid commented Aug 21, 2024

Description

I added a few UI fixes/enhancements

  1. Added hover highlighting
    Buttons already got fully highlighted when checked or pressed. Now they get partially highlighted when hovered

Samples of before (no visual change when mouse hovers the buttons shown)
before1
before2
before3

samples of after - mouse hover highlights slightly (dark mode)
after10
after20
after30

samples of after - mouse hover highlights slightly (light mode)
after-light-10
after-light-20
after-light-30

  1. Make some fixes to the "Palette Test" page
    the light/dark toggle button was broken and some of the QGCComponent examples lookes messed up

before
before-QmlType

after
after-qmlType

  1. Fix QGC icon
    The QGC icon shown in the top left corner of the app did not match the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon

before
a-before

after
a-after

  1. fix padding on launch card

before
z-before

after
z-afer

@HTRamsey HTRamsey requested a review from DonLakeFlyer August 21, 2024 02:43
@gillamkid gillamkid changed the title Make some UI fixes UI fixes Aug 21, 2024
@DonLakeFlyer
Copy link
Contributor

Thanks for all the nice cleanup. I'll take a look.

@DonLakeFlyer
Copy link
Contributor

If you look at QGCButton you'll see that hoverEnabled is disabled on mobile builds. This works around a problem where the hover would get stuck on for android. Since there really isn't "hover" on touch systems this fixes the problem without really changing any ui behavior.

So for any control which uses a raw Button as base and has had hover support added to it this same hoverEnabled things needs to be there.

These changes affect all button controls except QGCButton. Seems like that should be changed as well to match don't you think?

The QGC icon shown in the top left corner of the app did not match the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon
The light/dark toggle button was broken and some of the QGCComponent examples lookes messed up
@gillamkid
Copy link
Contributor Author

If you look at QGCButton you'll see that hoverEnabled is disabled on mobile builds. This works around a problem where the hover would get stuck on for android. Since there really isn't "hover" on touch systems this fixes the problem without really changing any ui behavior.

So for any control which uses a raw Button as base and has had hover support added to it this same hoverEnabled things needs to be there.

These changes affect all button controls except QGCButton. Seems like that should be changed as well to match don't you think?

@DonLakeFlyer, I made the changes you suggested to set hoverEnabled and make QGCButton have the same hover behavior. Should be good to go now!

@gillamkid gillamkid force-pushed the gillamkid/ui-fixes branch 2 times, most recently from 5ef8c75 to d3f05f2 Compare August 22, 2024 15:09
@gillamkid
Copy link
Contributor Author

gillamkid commented Aug 23, 2024

@DonLakeFlyer, this is ready for a second round of review! I made the changes you suggested but haven't added anything else. After I added my fixes I re-did the commits so the fixes are squashed into the commit they originated from.

Let me know what your preferred modify-current-PR strategy is. If you'd prefer me to not squash and keep the fix commits separate for easy second round review I could do that next time

@mrpollo
Copy link
Member

mrpollo commented Sep 4, 2024

As discussed on the PX4 dev call @gillamkid please split this into atomic changes so we can get reviewed, thank you for your contribution!

@gillamkid gillamkid closed this Sep 4, 2024
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-sep-4-2024/40534/1

@DonLakeFlyer
Copy link
Contributor

@gillamkid Closed because you are going to make new pull?

@gillamkid
Copy link
Contributor Author

@DonLakeFlyer yes, making some smaller PRs with the individual pieces. It will make reviewing them much easier.

@gillamkid gillamkid changed the title UI fixes WIP: UI fixes Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants