-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: UI fixes #11796
WIP: UI fixes #11796
Conversation
Thanks for all the nice cleanup. I'll take a look. |
If you look at QGCButton you'll see that So for any control which uses a raw These changes affect all button controls except QGCButton. Seems like that should be changed as well to match don't you think? |
The QGC icon shown in the top left corner of the app did not match the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon
The light/dark toggle button was broken and some of the QGCComponent examples lookes messed up
5ae8e14
to
eb1e9f5
Compare
@DonLakeFlyer, I made the changes you suggested to set |
5ef8c75
to
d3f05f2
Compare
@DonLakeFlyer, this is ready for a second round of review! I made the changes you suggested but haven't added anything else. After I added my fixes I re-did the commits so the fixes are squashed into the commit they originated from. Let me know what your preferred modify-current-PR strategy is. If you'd prefer me to not squash and keep the fix commits separate for easy second round review I could do that next time |
As discussed on the PX4 dev call @gillamkid please split this into atomic changes so we can get reviewed, thank you for your contribution! |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
@gillamkid Closed because you are going to make new pull? |
@DonLakeFlyer yes, making some smaller PRs with the individual pieces. It will make reviewing them much easier. |
Description
I added a few UI fixes/enhancements
Buttons already got fully highlighted when checked or pressed. Now they get partially highlighted when hovered
Samples of before (no visual change when mouse hovers the buttons shown)
samples of after - mouse hover highlights slightly (dark mode)
samples of after - mouse hover highlights slightly (light mode)
the light/dark toggle button was broken and some of the QGCComponent examples lookes messed up
before
after
The QGC icon shown in the top left corner of the app did not match the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon
before
after
before
after