ADSB: Add Unit Test #11782
Merged
ADSB: Add Unit Test #11782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-adsb
branch
5 times, most recently
from
474b774 to
aa6b5bd
Compare
DonLakeFlyer
reviewed
Sep 6, 2024
| } | ||
|
|
||
| _toolbox->adsbVehicleManager()->adsbVehicleUpdate(vehicleInfo); | ||
| (void) QMetaObject::invokeMethod(ADSBVehicleManager::instance(), "adsbVehicleUpdate", Qt::AutoConnection, vehicleInfo); |
There was a problem hiding this comment.
I don't quite get why this would be an invokeMethod. What is the reasoning behind when to use invokeMethod can when to call the method directly?
There was a problem hiding this comment.
I believe it's mostly just standard Qt practice to call slots with that now, so that connection type can be handled automatically even if you know it will be a direct call. QtCreator even has a tool to automatically convert to invokeMethod now because of how often they use it in their source.
There was a problem hiding this comment.
Ok, still seems a bit odd. But I guess future-proof for possible changes on called object down the road.
DonLakeFlyer
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a unit test for ADSB
Remove need for restarting app when changing ADSB enabled setting
Better handling of TCPLink state
Change from Tool to Application Static to reduce linking and make better isolated/testable module
General code quality improvements