Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow panics, unreachables, and expects using clippy lints #205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented Jan 17, 2025

Now that we're relatively stable, we can disallow the usage of these quite dangerous invocations.

We don't want to let any of those slip through reviews and it allows people that write PRs know ahead of time that they shouldn't be used.

Depends on #204 since that removes a panic that shouldn't exist.

This ensures that we don't add panics and expects in the codebase unless
we explicitly allow it for each individual invocation.
@poljar poljar requested a review from dkasak as a code owner January 17, 2025 16:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (3d655ad) to head (ca06697).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          34       34           
  Lines        1986     1986           
=======================================
  Hits         1795     1795           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants