Dev main #357
Merged
Dev main #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for command textbox
…ink in table (#354) * add build table to command step and link to skipped logs * add skipped log link in status as well * fix pipeline failure * temp commit for checkout * update as per review comments * remove MatlabBuild.java and update tests * temp commit for checkout * update as per review * fix pipeline failure * format code * remove teardown method overriding * add super to method calls
* Add skipReason in build results table * add skip reason texts * add test and bump Maven task * remove .idea from gitignore in this branch * update as per review comments * update as per review * update function name * update build results table * update test * update skip link * update status to succeeded * update data constructor
|
LGTM! The bug fixes are working as expected on Windows, Linux and Mac. There is a minor issue #359 but I think this need not be a blocker for the release. |
Vahila
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.