Support <ReferenceOneField emptyContent>
#10450
Open
+151
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Jan 17, 2025
| }); | ||
|
|
||
| export const EmptyText = () => ( | ||
| <AdminContext dataProvider={dataProvider} i18nProvider={i18nProvider}> |
There was a problem hiding this comment.
Can you wrap this story inside a TestMemoryRouter?
Comment on lines
69
to
77
| const renderEmptyItemOption = useCallback(() => { | ||
| return typeof emptyText === 'string' ? ( | ||
| <Typography component="span" variant="body2"> | ||
| {emptyText && translate(emptyText, { _: emptyText })} | ||
| </Typography> | ||
| ) : emptyText ? ( | ||
| emptyText | ||
| ) : null; | ||
| }, [emptyText, translate]); |
There was a problem hiding this comment.
You don't need all this. Just add the useCallback function content directly where you currently call it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10185
Problem
We cannot pass a ReactNode to
ReferenceOneFieldwhen we don't have any record, we can only pass text.Solution
Support
ReactElementin<ReferenceOneField emptyText>How To Test
https://react-admin-storybook-gzj7x0njd-marmelab.vercel.app/?path=/story/ra-ui-materialui-fields-referenceonefield--empty-text
Additional Checks
masterfor a bugfix, ornextfor a feature