As Gilbert, I want to see a more realistic representation of connect 4 game #7
Conversation
…he monorepo. Create the spa app with a bootstrap Home.
There was a problem hiding this comment.
👍
Personally, I would have added a makefile, as it takes very little time to set up. But you've already told me you'd do it at another time.
I haven't looked into the details of putting the CLI in a separate package, I think the code has already been checked beforehand.
In any case, both projects ran without a hitch on my side.
By the way, the CI doesn't work, is that normal?
| ], | ||
| "author": "Marmelab", | ||
| "license": "MIT", | ||
| "workspaces": [ |
There was a problem hiding this comment.
praise: Nice, It seems to work well for me!
| "description": "Mono repo for playing the game Connect Four as CLI or SPA.", | ||
| "scripts": { | ||
| "build": "npm run build --workspace connect-four-reboo-cli && npm run build --workspace connect-four-reboot-spa", | ||
| "dev": "npm run dev --workspace connect-four-reboo-cli & npm run dev --workspace connect-four-reboot-spa", |
There was a problem hiding this comment.
question: I don't quite see the point of launching both projects at the same time. Plus, it polishes up the console. I would have preferred two distince commands, because then I have to write the command myself and I'm lazy.
| @@ -0,0 +1,10 @@ | |||
| import React from "react"; | |||
| import App from "./app"; | |||
There was a problem hiding this comment.
suggestion: Personal opinion, I like to use airbnb's for naming components.
https://github.com/airbnb/javascript/tree/master/react#naming
https://trello.com/c/BFvCUpco/35-1-as-gilbert-i-want-to-see-a-more-realistic-representation-of-connect-4-game