Detect winner #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
detect-winner
branch
from
7ea1e80 to
ae7e231
Compare
…game). Added victoryState model to handle fourLine's winner coordinates. Updated winner tests to test fourLineCoordinates. Added winner detection and fourLine display.
atilbian
requested changes
Jan 17, 2025
Comment on lines
+399
to
+448
| describe("getWinner", () => { | ||
| it("should return false for isDraw with an empty board", () => { | ||
| expect( | ||
| getWinner([ | ||
| [0, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 0], | ||
| ]), | ||
| ).toStrictEqual({ | ||
| player: PlayerNum.empty, | ||
| fourLineCoordinates: [], | ||
| isDraw: false, | ||
| }); | ||
| }); | ||
|
|
||
| it("should return false for an ongoing board", () => { | ||
| expect( | ||
| getWinner([ | ||
| [0, 0, 0, 0, 1, 0, 0], | ||
| [0, 0, 0, 0, 2, 0, 0], | ||
| [0, 2, 1, 0, 2, 0, 0], | ||
| [0, 2, 1, 1, 2, 0, 2], | ||
| [0, 1, 1, 2, 1, 1, 1], | ||
| [0, 2, 2, 1, 1, 2, 2], | ||
| ]), | ||
| ).toStrictEqual({ | ||
| player: PlayerNum.empty, | ||
| fourLineCoordinates: [], | ||
| isDraw: false, | ||
| }); | ||
| }); | ||
| it("should return true for a full board without winner", () => { | ||
| expect( | ||
| getWinner([ | ||
| [1, 1, 2, 2, 1, 1, 2], | ||
| [2, 2, 1, 1, 2, 2, 1], | ||
| [1, 1, 2, 2, 1, 1, 2], | ||
| [2, 2, 1, 1, 2, 2, 1], | ||
| [1, 1, 2, 2, 1, 1, 2], | ||
| [2, 2, 1, 1, 2, 2, 1], | ||
| ]), | ||
| ).toStrictEqual({ | ||
| player: PlayerNum.empty, | ||
| fourLineCoordinates: [], | ||
| isDraw: true, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
suggestion: As it is duplicated with above tests I think we could remove these tests
There was a problem hiding this comment.
Why ? this test the ability to check draw game vs full board (maybe I can remove the first two...)
atilbian
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.