Fix autoconfigure for weird PWMs #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroy
force-pushed
the
autoconfig
branch
2 times, most recently
from
13b0bd8 to
bd5430a
Compare
This patch fixes fan autoconfiguration for weird PWMs that have non-1:1 value maps. In particular, it fixes the construction of the RPM curve data to properly use the PWM value map computed just before. This patch also adds a config option and flag to set the delay between setting a PWM value and observing the fan RPM sensor to support a wide range of controllers and fans. A long delay can lead to system overheating. The default is 2 seconds. This patch also changes a few other delays in the initialization code, namely the delay between setting a PWM value and observing the PWM value (to detect controllers that alter/quantize/adjust PWM values). It is hardcoded to 5 milliseconds.
|
Looks good, thx! 🚀 ❤️ 🤓 |
|
Thanks for fixing the config file, I somehow forgot about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes fan autoconfiguration for weird PWMs that have non-1:1 value maps. In particular, it fixes the construction of the RPM curve data to properly use the PWM value map computed just before.
This patch also extends a few sleeps to give slow PWMs/fans more time to react to requested changes.