-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manual-cn #2716
base: master
Are you sure you want to change the base?
manual-cn #2716
Conversation
translated Changelog.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace the images with symlinks to ../manual/...
to save space and avoid unneeded duplicates:
➜ manual git:(manual-cn) find . -type f|egrep "png|gif"
./images/manticore_database_flow_1.png
./Searching/autocomplete_github_demo.png
./Searching/didyoumean.png
./Searching/Full_text_matching/graphviz.png
./Searching/autocomplete.png
./Searching/faceted.png
./Searching/fuzzysearch.png
./Connecting_to_the_server/cli_browser.png
./manticore_database_flow_2.png
./mnt.cr.gif
./Node_info_and_management/Profiling/graphviz.png
./4.2.0_ps_on_vs_off.png
Done. |
@Nick-S-2018 Many links are now broken due to changes in the section titles, for example:
Can we improve the Attaching the whole diff with the invalid links: |
@sanikolaev Still in progress? |
@vergil-lai Yes, unfortunately, the issue with anchors can't be fixed just by improving the script:
We'll need to update all the links manually or find another automation solution. |
Let me try write a new script. if cant work i will fix it manually. |
OK, thank you very much. |
@sanikolaev |
@sanikolaev hi, how about this? |
@vergil-lai Hi. Sorry we were sidetracked by urgent issues. Thanks for your fixes. I'm testing them now. |
@vergil-lai there are still some invalid links. Here's a diff from our validation script Can you please look into this? |
Ok, i will fixed it latter. BTW, i havnt fix ChangeLog.md, Coz many bad link. |
Do you mean there are a lot of broken links? Can you please provide a few examples? |
Sorry, im busy recently, I will fix it. |
No worries. Take your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some invalid links.
yes, i will fix it recently |
Sorry, I've been a bit busy with my new job recently. |
Happy New Year, @vergil-lai, and congrats on the new job! Thanks for the commit. There are still some broken links left. I've marked them with ⛔ in the latest commit, so it's easier to find and fix them. |
commited. |
Type of Change (select one):
Description of the Change:
Chinese documents