Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tlcs900 variant: TMP94C241 #13220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipesanches
Copy link
Contributor

Used on the KN5000 driver.

Used on the KN5000 driver.
@felipesanches
Copy link
Contributor Author

Before/after comparison

On current git master, the screen gets almost completely black with just a glitch of half a dozen colored pixels at the top line:
image

With the new CPU variant implemented in this PR, we get a good-looking system message regarding control-panel MCU communications error:
Screenshot From 2025-01-12 04-01-12

@felipesanches
Copy link
Contributor Author

This PR is a followup to previous work done at #12684. I believe that I have already addressed all issues pointed out by @cuavas in his previous code review. In this PR I have included only the implementation of the new CPU variant and the small snippets of code in the KN5000 driver that use features on this variant.

The rest of the code for the kn5000 driver will be submitted as separate PRs later to make it easier to review and merge smaller chunks of code.

@wilbertpol and/or @ajrhacker, as you both are listed as authors of other variants of the TLCS900 family, could you please take a look at this PR?

@felipesanches
Copy link
Contributor Author

Note: The wording of the ** ERROR in CPU data transmission ** message is a bit misleading. I know it is related to the control panel MCUs due to this description in the service manual:

image

@felipesanches
Copy link
Contributor Author

To make that work, I'll need to implement UART support in the TMP94C241 CPU device and then use it to attach the MCUs (with HLE initially). But I'd like to land this PR before attempting that, as the amount of code needing review keeps growing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant