-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sinclair/tsconf.cpp: Added TR-DOS with virutal drives #13202
base: master
Are you sure you want to change the base?
Conversation
src/mame/sinclair/tsconf.cpp
Outdated
{ | ||
map(0x0000, 0xffff).lrw8( | ||
NAME([this](offs_t offset) { return m_ioext.read_byte((m_beta->dos_io_r() << 16) | offset); }), | ||
NAME([this](offs_t offset, u8 data) { m_ioext.write_byte((m_beta->dos_io_r() << 16) | offset, data); })); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you find a way to do this with a memory_view
, rather than effectively creating an address_map_bank_device
in all but name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is mainly to support configuration through zxbus. I took this approach previously because zxbus is required to handle 17 bit IO where all 3 combinations are available: shadow only, only !shadow, and both.
It's not clear if such case is possible to implement using banks or memviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you have a view with two entries, one for shadow and one for !shadow, then have devices install to one or both of the entries? Are there actually cases where something uses the 17th bit as an address bit rather than just a select bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it still not clear for me how can we pull desired view in zxbus when installing device in IO space?
mame/src/devices/bus/spectrum/zxbus.h
Line 91 in c5c1883
m_iospace->install_device(addrstart, addrend, device, map, unitmask); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've switched this PR to the views. I'll revisit zxbus mapping later as it's not critical for this work.
No description provided.