Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove caniuse-lite from dependency list #3861

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented May 19, 2022

Description

In #3842 we finally fixed the repeated Browserslist: caniuse-lite is outdated. Please run: npx browserslist@latest --update-db message, but the dependency was left behind in the package.json. If left this way, every time the browserlist is updated (quite often), our lock file will get out of sync. Running this script should add -> install -> remove this dependency so its only in the lock file, so I propose removing this dependency, and running that command as needed. I hope this doesn't mean that message comes back as soon as we're one patch behind, but we can keep it the way it is if we'd prefer frequent updates to the lock over this message.

Related Issue

Closes #NOJIRA

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@tjwiebell tjwiebell force-pushed the tommy/browserlist-fix branch from c449f21 to d612394 Compare May 19, 2022 15:17
@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label May 19, 2022
@tjwiebell tjwiebell requested a review from jimbo May 19, 2022 15:18
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 19, 2022

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against df28cb9

@dpatil-magento
Copy link
Contributor

@jimbo Please review changes when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: ready for review version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants