DM-46486: added check for units of flux field #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Sep 24, 2024
| @@ -715,6 +711,13 @@ class which intersect or are contained within the specified region. The | |||
| expandedCat = expandedCat.copy(deep=True) | |||
|
|
|||
| fluxField = getRefFluxField(expandedCat.schema, filterName) | |||
|
|
|||
| if expandedCat.schema[fluxField].asField().getUnits() != 'nJy': | |||
There was a problem hiding this comment.
This should be double quotes for consistency.
psferguson
force-pushed
the
tickets/DM-46486
branch
from
708bcf9 to
bb50012
Compare
psferguson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved version check to later and only conduct version check if fluxField has no units or incorrect units