DM-42087: Improve data masking and add utility function #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Sep 12, 2024
| Parameters | ||
| ---------- | ||
| line : `Line` | ||
| Line for which to fine the endpoints. |
There was a problem hiding this comment.
Suggested change
| Line for which to fine the endpoints. | |
| Line for which to find the endpoints. |
Comment on lines
50
to
53
| chi2: float = 0 | ||
| modelMaximum: float = 0 |
There was a problem hiding this comment.
Please add a description of these two attributes somewhere in the class doc string
| (x, y) coordinates of the start and endpoints of the line. | ||
| """ | ||
| theta = line.theta * u.deg | ||
| # Get where the line intersects with each line making up bounding box. |
There was a problem hiding this comment.
Suggested change
| # Get where the line intersects with each line making up bounding box. | |
| # Determine where the line intersects with each edge of the bounding box. |
| streaksMaskPlane = pexConfig.Field( | ||
| doc="Name of mask plane holding detected streaks", | ||
| dtype=str, | ||
| default="STREAK" | ||
| ) | ||
| badMaskPlanes = pexConfig.ListField( | ||
| doc="Names of mask planes to use when masking out regions.", |
There was a problem hiding this comment.
Suggested change
| doc="Names of mask planes to use when masking out regions.", | |
| doc="Names of mask plane regions to ignore entirely when doing streak detection.", |
| @@ -479,7 +535,15 @@ def find(self, maskedImage): | |||
| mask = maskedImage.mask | |||
| detectionMask = (mask.array & mask.getPlaneBitMask(self.config.detectedMaskPlane)) | |||
|
|
|||
| self.edges = self._cannyFilter(detectionMask) | |||
| initEdges = self._cannyFilter(detectionMask) | |||
| # Mask out edges of bad regions. | |||
There was a problem hiding this comment.
Suggested change
| # Mask out edges of bad regions. | |
| # Ignore regions with known bad masks, and add a one-pixel buffer around each. |
cmsaunders
force-pushed
the
tickets/DM-42087
branch
from
ac47215 to
c793daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.