DM-38632: Add NormalizedCompensatedFluxTask and update aperture corrections. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a task docstring.
taranu
reviewed
Jun 12, 2024
doc/lsst.meas.algorithms/tasks/lsst.meas.algorithms.NormalizedCalibrationFluxTask.rst
Outdated
Show resolved
Hide resolved
| """ | ||
| ConfigClass = MeasureApCorrConfig | ||
| _DefaultName = "measureApCorr" | ||
|
|
||
| def __init__(self, schema, **kwargs): | ||
| def __init__(self, schema, namesToCorrect=None, **kwargs): | ||
| """Construct a MeasureApCorrTask | ||
|
|
||
| For every name in lsst.meas.base.getApCorrNameSet(): |
There was a problem hiding this comment.
I think this can be removed now that the class has a docstring.
This workaround ensures that the overall offset is less susceptable to small outliers. This is not an ideal solution, but does help statistics until we can get a full rethink of the aperture correction code.
erykoff
force-pushed
the
tickets/DM-38632
branch
from
9078e89 to
88eda44
Compare
The default normalizes the 12 pixel aperture compensated tophat flux, and the normalization has 1 term (order 0). The task can also be used for more complicated mappings such as compensated gaussians (though in practice those had unacceptable scatter).
erykoff
force-pushed
the
tickets/DM-38632
branch
from
88eda44 to
d040808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with the new NormalizedCompensatedFluxTask (to normalize compensated tophats and gaussians) this adds a new "median shift" to the aperture corrections that helps reduce scatter in wide field images.