Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48145: Minor cleanups in UpdateVisitSummary #84

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

TallJimbo
Copy link
Member

No description provided.

Copy link
Contributor

@leeskelvin leeskelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nice clean-up, thanks!

The runQuantum method always provides PSF and ApCorr overrides, and
linting shows that providing ApCorr without PSF was silently broken
already.
@TallJimbo TallJimbo merged commit a96107c into main Jan 9, 2025
3 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-48145 branch January 9, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants