Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-46980: Implement dome homing in MTCS #174

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

cvillalon
Copy link
Contributor

@cvillalon cvillalon commented Oct 28, 2024

This implementation encodes the manual procedure to home the MTDome azimuth including the case where the reference azimuth position is lost, and the encoders are not reading the real position of the dome azimuth.

@cvillalon cvillalon requested a review from tribeiro October 29, 2024 14:26
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here some initial comments.. look pretty good, just some minor comments...

python/lsst/ts/observatory/control/maintel/mtcs.py Outdated Show resolved Hide resolved
python/lsst/ts/observatory/control/maintel/mtcs.py Outdated Show resolved Hide resolved
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments.. also I think you need to rebase this.

python/lsst/ts/observatory/control/maintel/mtcs.py Outdated Show resolved Hide resolved
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! please, rebase before merging.

@cvillalon cvillalon merged commit 09ee0a6 into develop Nov 11, 2024
5 checks passed
@cvillalon cvillalon deleted the tickets/DM-46980 branch November 11, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants