-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tickets/DM-46980: Implement dome homing in MTCS #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here some initial comments.. look pretty good, just some minor comments...
9d149af
to
0ef03f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more comments.. also I think you need to rebase this.
0ef03f8
to
ccac84a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! please, rebase before merging.
ccac84a
to
2ac253e
Compare
This implementation encodes the manual procedure to home the MTDome azimuth including the case where the reference azimuth position is lost, and the encoders are not reading the real position of the dome azimuth.